Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update int test ttls to be more lenient #441

Merged
merged 6 commits into from
May 15, 2023
Merged

Conversation

bruuuuuuuce
Copy link
Contributor

@bruuuuuuuce bruuuuuuuce commented May 12, 2023

When running these integration tests in region in an aws account, we were seeing flaky results. It seems to be due to the fact that we return keys/values even slightly after they are ttl'd out. This pr relaxes some of the integration test timeouts to allow some leniency in their timeouts/ttls.

Testing in fargate, these changes are passing now

@bruuuuuuuce bruuuuuuuce marked this pull request as ready for review May 12, 2023 20:15
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, could you extract the TTLs and wait times on these tests to static fields? A lot of the constants are repeated (mostly due to me 😬 ).

@bruuuuuuuce bruuuuuuuce requested a review from malandis May 15, 2023 20:22
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is much better. Just one last change then we're good to go.

tests/Integration/Momento.Sdk.Tests/Utils.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❇️

@bruuuuuuuce bruuuuuuuce merged commit b215a2e into main May 15, 2023
@bruuuuuuuce bruuuuuuuce deleted the fix/flakyIntTests branch May 15, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants