-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update int test ttls to be more lenient #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're here, could you extract the TTLs and wait times on these tests to static fields? A lot of the constants are repeated (mostly due to me 😬 ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This is much better. Just one last change then we're good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❇️
When running these integration tests in region in an aws account, we were seeing flaky results. It seems to be due to the fact that we return keys/values even slightly after they are ttl'd out. This pr relaxes some of the integration test timeouts to allow some leniency in their timeouts/ttls.
Testing in fargate, these changes are passing now